cloudspades: add linux-aarch64 build #51446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.circleci/config.yml (1)
Line range hint
1-385: Overall configuration review: ARM support looks comprehensiveThe CircleCI configuration for ARM support (both osx-arm64 and linux-aarch64) appears comprehensive and well-structured. It covers various scenarios including PR builds, master branch builds, bulk builds, and nightly builds. The separation of concerns between different job types is commendable.
Consider the following suggestions for further improvements:
- Caching: Implement caching strategies for dependencies to speed up builds.
- Parallelization: Explore opportunities to parallelize steps within jobs where possible.
- Conditional Execution: Implement more granular conditional execution to skip unnecessary steps based on the changes in a PR.
- Error Handling: Enhance error handling and reporting, especially for the bulk and nightly builds.
- Documentation: Add inline comments explaining the purpose of critical or complex steps.
To verify the effectiveness of the current configuration, you can run the following script to analyze job success rates:
#!/bin/bash # Description: Analyze job success rates for ARM builds # Note: Ensure you have the CircleCI CLI installed and configured # Function to get success rate for a job get_success_rate() { local job_name=$1 local total=$(circleci job list bioconda/bioconda-recipes --filter "$job_name" --limit 100 | jq '.total_items') local success=$(circleci job list bioconda/bioconda-recipes --filter "$job_name" --limit 100 | jq '.items[] | select(.status == "success") | .id' | wc -l) echo "scale=2; $success / $total * 100" | bc } echo "Success rates for ARM builds:" echo "build_and_test (osx-arm64): $(get_success_rate 'build_and_test-osx-arm64')%" echo "build_and_test (linux-aarch64): $(get_success_rate 'build_and_test-linux-aarch64')%" echo "build_and_upload (osx-arm64): $(get_success_rate 'build_and_upload-osx-arm64')%" echo "build_and_upload (linux-aarch64): $(get_success_rate 'build_and_upload-linux-aarch64')%" echo "bulk_build (linux-aarch64): $(get_success_rate 'bulk_build-linux-aarch64')%" echo "nightly_build (linux-aarch64): $(get_success_rate 'nightly_build-linux-aarch64')%"This script will help identify any jobs that may need attention due to low success rates.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- .circleci/config.yml (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
.circleci/config.yml (1)
12-12: Approved: Increased resource class for linux-aarch64 executorThe change from
arm.mediumtoarm.largefor the linux-aarch64 executor is appropriate for supporting the new ARM64 build. This should provide more resources for potentially resource-intensive builds.To ensure this change is beneficial:
- Monitor build times and success rates for linux-aarch64 builds after this change.
- Compare resource utilization between arm.medium and arm.large to justify the increased cost.
Run the following script to check recent build times for linux-aarch64:
This will help in assessing the impact of the resource class change on build performance.
|
@BiocondaBot please fetch artifacts |
|
Package(s) built are ready for inspection:
Docker image(s) built:
|
LGTM! |
|
@BiocondaBot please add label |
rpetit3
approved these changes
Oct 17, 2024
Merged
This was referenced Oct 21, 2024
This was referenced Oct 29, 2024
This was referenced Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.